From 3c3269b30ea7fe4a1dbd66ac2972dcfa9f25c8e1 Mon Sep 17 00:00:00 2001 From: Debao Zhang Date: Mon, 10 Mar 2014 15:46:04 +0800 Subject: [PATCH] Add assert for row==0 and col==0 As some users consider that (0, 0) is the first valid cell, so we give a assert failure in debug mode for such cases. --- src/xlsx/xlsxworksheet.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xlsx/xlsxworksheet.cpp b/src/xlsx/xlsxworksheet.cpp index fea572f..4f3509a 100755 --- a/src/xlsx/xlsxworksheet.cpp +++ b/src/xlsx/xlsxworksheet.cpp @@ -147,6 +147,9 @@ QString WorksheetPrivate::generateDimensionString() const */ int WorksheetPrivate::checkDimensions(int row, int col, bool ignore_row, bool ignore_col) { + Q_ASSERT_X(row!=0, "checkDimensions", "row should start from 1 instead of 0"); + Q_ASSERT_X(col!=0, "checkDimensions", "column should start from 1 instead of 0"); + if (row > XLSX_ROW_MAX || row < 1 || col > XLSX_COLUMN_MAX || col < 1) return -1;