From 6ee507b0d84dc57965ea1c79d89e278faa21b1a0 Mon Sep 17 00:00:00 2001
From: Debao Zhang <hello@debao.me>
Date: Wed, 11 Sep 2013 17:12:56 +0800
Subject: [PATCH] Make constructor of Workbook private

---
 src/xlsx/xlsxworkbook.cpp                     | 26 +++++++++++++++++
 src/xlsx/xlsxworkbook.h                       | 15 ++++++++--
 tests/auto/mergecell/tst_mergecelltest.cpp    | 29 +++++++++----------
 .../relationships/tst_relationshipstest.cpp   | 10 ++-----
 4 files changed, 54 insertions(+), 26 deletions(-)

diff --git a/src/xlsx/xlsxworkbook.cpp b/src/xlsx/xlsxworkbook.cpp
index 87b650e..2be82f3 100755
--- a/src/xlsx/xlsxworkbook.cpp
+++ b/src/xlsx/xlsxworkbook.cpp
@@ -33,6 +33,7 @@
 #include "xlsxworksheet_p.h"
 
 #include <QFile>
+#include <QBuffer>
 
 namespace QXlsx {
 
@@ -281,4 +282,29 @@ void Workbook::saveToXmlFile(QIODevice *device)
     writer.writeEndDocument();
 }
 
+QByteArray Workbook::saveToXmlData()
+{
+    QByteArray data;
+    QBuffer buffer(&data);
+    buffer.open(QIODevice::WriteOnly);
+    saveToXmlFile(&buffer);
+
+    return data;
+}
+
+QSharedPointer<Workbook> Workbook::loadFromXmlFile(QIODevice *device)
+{
+
+    return QSharedPointer<Workbook>(new Workbook);
+}
+
+QSharedPointer<Workbook> Workbook::loadFromXmlData(const QByteArray &data)
+{
+    QBuffer buffer;
+    buffer.setData(data);
+    buffer.open(QIODevice::ReadOnly);
+
+    return loadFromXmlFile(&buffer);
+}
+
 } //namespace
diff --git a/src/xlsx/xlsxworkbook.h b/src/xlsx/xlsxworkbook.h
index dc55783..cdd5959 100755
--- a/src/xlsx/xlsxworkbook.h
+++ b/src/xlsx/xlsxworkbook.h
@@ -29,6 +29,8 @@
 #include <QObject>
 #include <QList>
 #include <QImage>
+#include <QSharedPointer>
+
 class QIODevice;
 
 namespace QXlsx {
@@ -39,6 +41,8 @@ class SharedStrings;
 class Styles;
 class Package;
 class Drawing;
+class Document;
+class DocumentPrivate;
 
 class WorkbookPrivate;
 class Q_XLSX_EXPORT Workbook : public QObject
@@ -46,7 +50,6 @@ class Q_XLSX_EXPORT Workbook : public QObject
     Q_OBJECT
     Q_DECLARE_PRIVATE(Workbook)
 public:
-    Workbook(QObject *parent=0);
     ~Workbook();
 
     QList<Worksheet *> worksheets() const;
@@ -66,13 +69,21 @@ public:
 private:
     friend class Package;
     friend class Worksheet;
+    friend class Document;
+    friend class DocumentPrivate;
+
+    Workbook(QObject *parent=0);
+
+    void saveToXmlFile(QIODevice *device);
+    QByteArray saveToXmlData();
+    static QSharedPointer<Workbook> loadFromXmlFile(QIODevice *device);
+    static QSharedPointer<Workbook> loadFromXmlData(const QByteArray &data);
 
     SharedStrings *sharedStrings();
     Styles *styles();
     QList<QImage> images();
     QList<Drawing *> drawings();
     void prepareDrawings();
-    void saveToXmlFile(QIODevice *device);
 
     WorkbookPrivate * const d_ptr;
 };
diff --git a/tests/auto/mergecell/tst_mergecelltest.cpp b/tests/auto/mergecell/tst_mergecelltest.cpp
index 6833d12..409c31c 100644
--- a/tests/auto/mergecell/tst_mergecelltest.cpp
+++ b/tests/auto/mergecell/tst_mergecelltest.cpp
@@ -2,7 +2,7 @@
 #include <QtTest>
 
 #include "xlsxworksheet.h"
-#include "xlsxworkbook.h"
+#include "xlsxdocument.h"
 
 class MergeCellTest : public QObject
 {
@@ -23,45 +23,42 @@ MergeCellTest::MergeCellTest()
 
 void MergeCellTest::testWithoutMerge()
 {
-    QXlsx::Workbook book;
-    QXlsx::Worksheet *sheet = book.addWorksheet("Sheet1");
-    sheet->write("B1", "Hello");
+    QXlsx::Document xlsx;
+    xlsx.write("B1", "Hello");
 
     QByteArray xmldata;
     QBuffer buffer(&xmldata);
     buffer.open(QIODevice::WriteOnly);
-    sheet->saveToXmlFile(&buffer);
+    xlsx.activedWorksheet()->saveToXmlFile(&buffer);
 
     QVERIFY2(!xmldata.contains("<mergeCell"), "");
 }
 
 void MergeCellTest::testMerge()
 {
-    QXlsx::Workbook book;
-    QXlsx::Worksheet *sheet = book.addWorksheet("Sheet1");
-    sheet->write("B1", "Test Merged Cell");
-    sheet->mergeCells("B1:B5");
+    QXlsx::Document xlsx;
+    xlsx.write("B1", "Test Merged Cell");
+    xlsx.mergeCells("B1:B5");
 
     QByteArray xmldata;
     QBuffer buffer(&xmldata);
     buffer.open(QIODevice::WriteOnly);
-    sheet->saveToXmlFile(&buffer);
+    xlsx.activedWorksheet()->saveToXmlFile(&buffer);
 
     QVERIFY2(xmldata.contains("<mergeCells count=\"1\"><mergeCell ref=\"B1:B5\"/></mergeCells>"), "");
 }
 
 void MergeCellTest::testUnMerge()
 {
-    QXlsx::Workbook book;
-    QXlsx::Worksheet *sheet = book.addWorksheet("Sheet1");
-    sheet->write("B1", "Test Merged Cell");
-    sheet->mergeCells("B1:B5");
-    sheet->unmergeCells("B1:B5");
+    QXlsx::Document xlsx;
+    xlsx.write("B1", "Test Merged Cell");
+    xlsx.mergeCells("B1:B5");
+    xlsx.unmergeCells("B1:B5");
 
     QByteArray xmldata;
     QBuffer buffer(&xmldata);
     buffer.open(QIODevice::WriteOnly);
-    sheet->saveToXmlFile(&buffer);
+    xlsx.activedWorksheet()->saveToXmlFile(&buffer);
 
     QVERIFY2(!xmldata.contains("<mergeCell"), "");
 }
diff --git a/tests/auto/relationships/tst_relationshipstest.cpp b/tests/auto/relationships/tst_relationshipstest.cpp
index f1bf954..51b9e7f 100644
--- a/tests/auto/relationships/tst_relationshipstest.cpp
+++ b/tests/auto/relationships/tst_relationshipstest.cpp
@@ -24,10 +24,7 @@ void RelationshipsTest::testSaveXml()
     QXlsx::Relationships rels;
     rels.addDocumentRelationship("/officeDocument", "xl/workbook.xml");
 
-    QByteArray xmldata;
-    QBuffer buffer(&xmldata);
-    buffer.open(QIODevice::WriteOnly);
-    rels.saveToXmlFile(&buffer);
+    QByteArray xmldata = rels.saveToXmlData();
 
     QVERIFY2(xmldata.contains("<Relationship Id=\"rId1\" Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument\" Target=\"xl/workbook.xml\"/>"), "");
 }
@@ -38,11 +35,8 @@ void RelationshipsTest::testLoadXml()
                        "<Relationships xmlns=\"http://schemas.openxmlformats.org/package/2006/relationships\">"
                        "<Relationship Id=\"rId1\" Type=\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument\" Target=\"xl/workbook.xml\"/>"
                        "</Relationships>");
-    QBuffer buffer(&xmldata);
-    buffer.open(QIODevice::ReadOnly);
 
-    QXlsx::Relationships rels;
-    rels.loadFromXmlFile(&buffer);
+    QXlsx::Relationships rels = QXlsx::Relationships::loadFromXmlData(xmldata);
 
     QCOMPARE(rels.documentRelationships("/officeDocument").size(), 1);
 }