From afbf4effbf03185b3f466edea18a0774dd57d4b8 Mon Sep 17 00:00:00 2001
From: Debao Zhang <hello@debao.me>
Date: Thu, 24 Oct 2013 16:30:56 +0800
Subject: [PATCH] Pass const QString by reference instead of by value

---
 src/xlsx/xlsxdocument.cpp  | 2 +-
 src/xlsx/xlsxdocument.h    | 2 +-
 src/xlsx/xlsxworksheet.cpp | 2 +-
 src/xlsx/xlsxworksheet.h   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/xlsx/xlsxdocument.cpp b/src/xlsx/xlsxdocument.cpp
index b320e1c..5ca994f 100644
--- a/src/xlsx/xlsxdocument.cpp
+++ b/src/xlsx/xlsxdocument.cpp
@@ -113,7 +113,7 @@ Format *Document::createFormat()
 /*!
  * Write \a value to cell \a row_column with the \a format.
  */
-int Document::write(const QString row_column, const QVariant &value, Format *format)
+int Document::write(const QString &row_column, const QVariant &value, Format *format)
 {
     return currentWorksheet()->write(row_column, value, format);
 }
diff --git a/src/xlsx/xlsxdocument.h b/src/xlsx/xlsxdocument.h
index 4c787ca..c651eab 100644
--- a/src/xlsx/xlsxdocument.h
+++ b/src/xlsx/xlsxdocument.h
@@ -53,7 +53,7 @@ public:
     ~Document();
 
     Format *createFormat();
-    int write(const QString cell, const QVariant &value, Format *format=0);
+    int write(const QString &cell, const QVariant &value, Format *format=0);
     int write(int row, int col, const QVariant &value, Format *format=0);
     int insertImage(int row, int column, const QImage &image, double xOffset=0, double yOffset=0, double xScale=1, double yScale=1);
     int mergeCells(const QString &range);
diff --git a/src/xlsx/xlsxworksheet.cpp b/src/xlsx/xlsxworksheet.cpp
index fd3f6c4..734705a 100755
--- a/src/xlsx/xlsxworksheet.cpp
+++ b/src/xlsx/xlsxworksheet.cpp
@@ -326,7 +326,7 @@ int Worksheet::write(int row, int column, const QVariant &value, Format *format)
 }
 
 //convert the "A1" notation to row/column notation
-int Worksheet::write(const QString row_column, const QVariant &value, Format *format)
+int Worksheet::write(const QString &row_column, const QVariant &value, Format *format)
 {
     QPoint pos = xl_cell_to_rowcol(row_column);
     if (pos == QPoint(-1, -1)) {
diff --git a/src/xlsx/xlsxworksheet.h b/src/xlsx/xlsxworksheet.h
index dea9d17..353e0b3 100755
--- a/src/xlsx/xlsxworksheet.h
+++ b/src/xlsx/xlsxworksheet.h
@@ -50,7 +50,7 @@ class Q_XLSX_EXPORT Worksheet
 {
     Q_DECLARE_PRIVATE(Worksheet)
 public:
-    int write(const QString row_column, const QVariant &value, Format *format=0);
+    int write(const QString &row_column, const QVariant &value, Format *format=0);
     int write(int row, int column, const QVariant &value, Format *format=0);
     int writeString(int row, int column, const QString &value, Format *format=0);
     int writeInlineString(int row, int column, const QString &value, Format *format=0);