From 586aaf7111950047e7654c69f8b604e2afe88976 Mon Sep 17 00:00:00 2001 From: probonopd Date: Sat, 21 Sep 2019 10:31:38 +0000 Subject: [PATCH] Additional check Additional check to make sure that the undocumented, unsupported and not recommended `-unsupported-allow-new-glibc` option is not abused to create results that are broken; see https://github.com/probonopd/linuxdeployqt/issues/340 for more information --- tools/linuxdeployqt/main.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/linuxdeployqt/main.cpp b/tools/linuxdeployqt/main.cpp index 00fbc96..fcdea9e 100644 --- a/tools/linuxdeployqt/main.cpp +++ b/tools/linuxdeployqt/main.cpp @@ -455,6 +455,14 @@ int main(int argc, char **argv) } } + /* Additional check to make sure that the undocumented, unsupported and not recommended + * -unsupported-allow-new-glibc option is not abused to create results that are broken; see + * https://github.com/probonopd/linuxdeployqt/issues/340 for more information + * TODO: Add funtionality that would automatically bundle glibc fully and correctly in this case */ + if(skipGlibcCheck == true){ + if(QFileInfo(appDirPath + "/usr/share/doc/libc6/copyright").exists() == false) exit(1); + } + /* Copy in place */ if(iconToBeUsed != ""){ /* Check if there is already an icon and only if there is not, copy it to the AppDir.